[BeEF] Fix file handle leak in copyright_update.rb#3557
Open
mitre88 wants to merge 1 commit intobeefproject:masterfrom
Open
[BeEF] Fix file handle leak in copyright_update.rb#3557mitre88 wants to merge 1 commit intobeefproject:masterfrom
mitre88 wants to merge 1 commit intobeefproject:masterfrom
Conversation
- Wrap File.open in a context manager (block) instead of storing the file handle in a local variable - Move function definition and main logic inside the block to ensure proper cleanup - Fix potential file descriptor leak if an exception occurred before log_file.close was called
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a file handle leak in
tools/maintenance/copyright_update.rb.Issue
The log file was opened using
File.open()without a block/context manager:If an exception occurred before
log_file.closewas called, the file descriptor would leak. This is especially problematic in a maintenance script that processes many files.Fix
File.openin a block (File.open(...) do |log_file|) so the file is automatically closed when the block endslog_file.closecall since it's no longer needed